Align pulses instead of blocks #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
March 26, 2018 15:16
General alignment of CompoundGates remains to be fixed
Not the cleanest thing to do, but there are different ways the alignment with a trigger can fail, for instance if the following element is a BlockLabel
|
Note that the standard |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to the issue presented in #92. This allows to specify any alignment between pulses using
align(mode, pulse1, pulse2).modecan be either 'left', 'center' (default), or 'right'.pulse1andpulse2can be any combination ofPulse,PulseBlock,CompositePulse. The alignment ofCompoundGatesis currently not supported (limited workaround for triggers).Note: this does not solve #148, but it's a step towards more flexibility.
Thoughts?