Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align pulses instead of blocks #157

Merged
merged 16 commits into from
Apr 24, 2018
Merged

Align pulses instead of blocks #157

merged 16 commits into from
Apr 24, 2018

Conversation

dieris
Copy link
Collaborator

@dieris dieris commented Apr 11, 2018

Alternative solution to the issue presented in #92. This allows to specify any alignment between pulses using align(mode, pulse1, pulse2). mode can be either 'left', 'center' (default), or 'right'. pulse1 and pulse2 can be any combination of Pulse, PulseBlock, CompositePulse. The alignment of CompoundGates is currently not supported (limited workaround for triggers).

Note: this does not solve #148, but it's a step towards more flexibility.

Thoughts?

@dieris dieris requested review from matthewware and gribeill April 11, 2018 20:28
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 69.876% when pulling 4ed8a75 on feature/align-pulses into a0b2956 on master.

@dieris
Copy link
Collaborator Author

dieris commented Apr 12, 2018

Note that the standard Pulse(q1)*Pulse(q2) still works and defaults to center alignment

@dieris dieris mentioned this pull request Apr 19, 2018
@dieris dieris merged commit f900947 into master Apr 24, 2018
@dieris dieris deleted the feature/align-pulses branch July 24, 2018 14:08
@dieris dieris mentioned this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants