Skip to content

Commit

Permalink
build(deps): upgrade SDK and packages (#145)
Browse files Browse the repository at this point in the history
  • Loading branch information
BBarisKilic authored Feb 28, 2025
2 parents cec4f66 + 79904e4 commit 725e6b8
Show file tree
Hide file tree
Showing 63 changed files with 1,876 additions and 2,254 deletions.
3 changes: 3 additions & 0 deletions .fvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"flutter": "3.29.0"
}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ unlinked_spec.ds
**/android/app/debug
**/android/app/profile
**/android/app/release
**/android/app/.cxx
*.jks

# iOS/XCode related
Expand Down
3 changes: 2 additions & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ analyzer:
- '**app_localizations**.dart'
- '**/generated_plugin_registrant.dart'

include: package:very_good_analysis/analysis_options.5.1.0.yaml
include: package:very_good_analysis/analysis_options.yaml
linter:
rules:
public_member_api_docs: false
avoid_catches_without_on_clauses: false
16 changes: 6 additions & 10 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
plugins {
id "com.android.application"
id "kotlin-android"
id "dev.flutter.flutter-gradle-plugin"
}

def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
Expand All @@ -6,11 +12,6 @@ if (localPropertiesFile.exists()) {
}
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '1'
Expand All @@ -27,10 +28,6 @@ if (keystorePropertiesFile.exists()) {
keystoreProperties.load(new FileInputStream(keystorePropertiesFile))
}

apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
namespace "com.example.numbers"
compileSdkVersion flutter.compileSdkVersion
Expand Down Expand Up @@ -114,5 +111,4 @@ flutter {
}

dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
}
13 changes: 0 additions & 13 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
buildscript {
ext.kotlin_version = '1.7.10'
repositories {
google()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:7.3.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}

allprojects {
repositories {
google()
Expand Down
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
30 changes: 22 additions & 8 deletions android/settings.gradle
Original file line number Diff line number Diff line change
@@ -1,11 +1,25 @@
include ':app'
pluginManagement {
def flutterSdkPath = {
def properties = new Properties()
file("local.properties").withInputStream { properties.load(it) }
def flutterSdkPath = properties.getProperty("flutter.sdk")
assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
return flutterSdkPath
}()

def localPropertiesFile = new File(rootProject.projectDir, "local.properties")
def properties = new Properties()
includeBuild("$flutterSdkPath/packages/flutter_tools/gradle")

assert localPropertiesFile.exists()
localPropertiesFile.withReader("UTF-8") { reader -> properties.load(reader) }
repositories {
google()
mavenCentral()
gradlePluginPortal()
}
}

def flutterSdkPath = properties.getProperty("flutter.sdk")
assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
apply from: "$flutterSdkPath/packages/flutter_tools/gradle/app_plugin_loader.gradle"
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "8.3.0" apply false
id "org.jetbrains.kotlin.android" version "1.8.22" apply false
}

include ":app"
5 changes: 1 addition & 4 deletions lib/bootstrap.dart
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,7 @@ Future<void> setup() async {
() => GetRandomNumberUseCase(repository: getIt()),
)
..registerFactory<AppCubit>(
() => AppCubit(
getThemeUseCase: getIt(),
saveThemeUseCase: getIt(),
),
() => AppCubit(getThemeUseCase: getIt(), saveThemeUseCase: getIt()),
)
..registerFactory<NumberCubit>(
() => NumberCubit(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ import 'package:numbers/src/core/core.dart';
import 'package:shared_preferences/shared_preferences.dart';

final class SharedPrefThemeService implements ThemeService {
SharedPrefThemeService({
required SharedPreferences preferences,
}) : _preferences = preferences;
SharedPrefThemeService({required SharedPreferences preferences})
: _preferences = preferences;

final SharedPreferences _preferences;

Expand Down
5 changes: 2 additions & 3 deletions lib/src/app/data/repositories/theme_repository_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import 'package:numbers/src/app/app.dart';
import 'package:numbers/src/core/core.dart';

final class ThemeRepositoryImpl implements ThemeRepository {
const ThemeRepositoryImpl({
required ThemeService service,
}) : _themeService = service;
const ThemeRepositoryImpl({required ThemeService service})
: _themeService = service;

final ThemeService _themeService;

Expand Down
5 changes: 2 additions & 3 deletions lib/src/app/domain/usecases/get_theme_usecase.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ import 'package:numbers/src/core/core.dart';

final class GetThemeUseCase
implements UseCase<DataState<String>, GetThemeParams> {
const GetThemeUseCase({
required ThemeRepository repository,
}) : _themeRepository = repository;
const GetThemeUseCase({required ThemeRepository repository})
: _themeRepository = repository;

final ThemeRepository _themeRepository;

Expand Down
5 changes: 2 additions & 3 deletions lib/src/app/domain/usecases/save_theme_usecase.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ import 'package:numbers/src/core/core.dart';

final class SaveThemeUseCase
implements UseCase<DataState<void>, SaveThemeParams> {
const SaveThemeUseCase({
required ThemeRepository repository,
}) : _themeRepository = repository;
const SaveThemeUseCase({required ThemeRepository repository})
: _themeRepository = repository;

final ThemeRepository _themeRepository;

Expand Down
13 changes: 7 additions & 6 deletions lib/src/app/presentation/cubit/app_cubit.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ final class AppCubit extends Cubit<AppState> {
AppCubit({
required GetThemeUseCase getThemeUseCase,
required SaveThemeUseCase saveThemeUseCase,
}) : _getThemeUseCase = getThemeUseCase,
_saveThemeUseCase = saveThemeUseCase,
super(const AppState(theme: AvailableTheme.dark));
}) : _getThemeUseCase = getThemeUseCase,
_saveThemeUseCase = saveThemeUseCase,
super(const AppState(theme: AvailableTheme.dark));

final GetThemeUseCase _getThemeUseCase;
final SaveThemeUseCase _saveThemeUseCase;
Expand All @@ -33,9 +33,10 @@ final class AppCubit extends Cubit<AppState> {
case DataSuccess(data: final theme):
emit(
state.copyWith(
theme: theme == AvailableTheme.light.value
? AvailableTheme.light
: AvailableTheme.dark,
theme:
theme == AvailableTheme.light.value
? AvailableTheme.light
: AvailableTheme.dark,
),
);
case DataFailure():
Expand Down
Loading

0 comments on commit 725e6b8

Please sign in to comment.