Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Program Management section of Admin Settings #1281

Merged
merged 87 commits into from
Dec 2, 2024
Merged

Refactor Program Management section of Admin Settings #1281

merged 87 commits into from
Dec 2, 2024

Conversation

Kafui123
Copy link
Contributor

@Kafui123 Kafui123 commented Jul 16, 2024 •
edited by bledsoef
Loading

Issue

Issue: #797

Changes

  • Created a modal to update the information displayed for the programs on the homepage.
  • Fields include program name, description, partner, contact email, contact name, and location.
  • Implemented a add a new file feature, to change the image of the programs on the homepage.
  • Saved changes button works as expected, and there are two ways to close the modal, cancel or cross button.
  • Partner, contact email, contact name, location all stored in database.
  • Program name, description, images and links can be directly seen in the home screen.
  • Added editable link for Instagram, Facebook and Berea URL.
  • Refactored testing function

Testing

  • Checkout refactorProgramMgmt
  • ./database/reset_database.sh test
  • flask run
  • Go to Admin -> Settings
  • Open up the Program Settings accordion
  • Click on 3-4 programs and upload a png to 2 and a jpg to 2.
  • Go to the landing page and make sure the landing page images for each program reflects what you uploaded.
  • Go to app/static/files/programattachments and make sure that there is only one file for each program (1.jpg, 2.png, etc.)
  • Once your testing has concluded delete all files that were just added and are not source controlled (pngs or any other different file types)
  • Run git restore .
  • If it does not properly add back all files that were initially there you may have to manually add them from GitHub or an earlier commit.

JohnCox2211 and others added 14 commits July 5, 2024 14:38
@JohnCox2211
New Branch with changes from previous. Image
f850ec3 
saving solution in route, currently get system
error.
@JohnCox2211
changed coverImage to be a blobfield. cleaned up
d5fe95d 
some white space and useless comments and moved
some css to its proper location. Image solution
still doesn't work, will ask a higher power about
it on monday
@JohnCox2211
More attempts for file handling, trying to modify
ebf80d2 
file handler, was trying to use userManagement.py
@JohnCox2211
Deleted partner.py because it was not being used
0053012 
except as a foreign key value in program to store
one charfield variable. Add some things to hopefully
handle files, not working. Updated the test data
to contain added data fields.
@JohnCox2211
added some notes about what returns are for
874a913 
some variables
@Kafui123
modified the modal so we could store the images of the filepaths
d1f035a
@Kafui123
modified image storing to database
230ee45
@Kafui123
we are on to something
decdb3d
@Kafui123
Fixed Issuegit status !
19c1b2c
Picture appeared, at some point of time, but it disappeared again. Cu…
be36260 
…rrently attempting to change the file name to the name of the program along with the file extension.
@Kafui123
changes we have made so far
a7eb026
Issue fixed, the modal works, the delete button does not close the mo…
e40eb96 
…dal and the msgToast is also in front of the modal and clearly visible.
@Kafui123
updated code that reflects all the changes that work
19040fd
@AravDe
Merge branch 'development' into refactorProgramMgmt
4702612
AravDe
AravDe reviewed Jul 17, 2024
View reviewed changes
app/logic/fileHandler.py Outdated Show resolved Hide resolved
Kafui123 and others added 15 commits July 17, 2024 14:42
@thealphagurlux
Copy link

When trying to upload a picture for a event, if you exit out of the modal and open it the file name will still be there and the same file will still be uploaded if saved.

I suggest clearing the picture and file name when the user exits the modal.

image

@thealphagurlux
Copy link

For the following programs, when trying to change the event picture in settings the picture doesn't change:

-Berea Teen Mentoring
-Hispanic Outreach Program
-People Who Care

@bledsoef
Copy link
Contributor

For the following programs, when trying to change the event picture in settings the picture doesn't change:

-Berea Teen Mentoring -Hispanic Outreach Program -People Who Care

@thealphagurlux I double checked these on my machine and Anna's and we could not replicate the issue you found.

@thealphagurlux
Copy link

For the following programs, when trying to change the event picture in settings the picture doesn't change:
-Berea Teen Mentoring -Hispanic Outreach Program -People Who Care

@thealphagurlux I double checked these on my machine and Anna's and we could not replicate the issue you found.

@thealphagurlux
Copy link

For the following programs, when trying to change the event picture in settings the picture doesn't change:
-Berea Teen Mentoring -Hispanic Outreach Program -People Who Care

@thealphagurlux I double checked these on my machine and Anna's and we could not replicate the issue you found.

I had not reset my database or restored the git branch while looking for bugs. This is what was causing the issue.

@BrianRamsay BrianRamsay reopened this Nov 19, 2024
Karina-Agliullova
Karina-Agliullova approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Karina-Agliullova Karina-Agliullova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@WackyWeaver WackyWeaver dismissed stale reviews from vungc and BrianRamsay December 2, 2024 20:49

No remaining comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

View Code Coverage

@WackyWeaver WackyWeaver merged commit 90449ed into development Dec 2, 2024
5 checks passed
@WackyWeaver WackyWeaver deleted the refactorProgramMgmt branch December 2, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AravDe AravDe AravDe left review comments

@Mbeweg Mbeweg Mbeweg left review comments

@WackyWeaver WackyWeaver WackyWeaver left review comments

@esw0624 esw0624 esw0624 left review comments

@Karina-Agliullova Karina-Agliullova Karina-Agliullova approved these changes

@BrianRamsay BrianRamsay BrianRamsay left review comments

@vungc vungc vungc left review comments

@thealphagurlux thealphagurlux Awaiting requested review from thealphagurlux

@ojmakinde ojmakinde Awaiting requested review from ojmakinde

Assignees

@bledsoef bledsoef

@WackyWeaver WackyWeaver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.