Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox Timepicker on Create Event #1356

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Conversation

bledsoef
Copy link
Contributor

@bledsoef bledsoef commented Nov 15, 2024

Issue Description

Fixes issue #1267

  • The create event start and end timepickers are not working on Firefox.

Changes

  • Imported flatpickr into the JS file and initialize it for non chrome browsers.
  • Attach a new flatpickr object to each datepicker created when a multiple offerings row is added.

Testing

  • Checkout development
  • Open up CELTS in Firefox
  • Verify date selecting does not work
  • Checkout 1267-timepicker-issue
  • Open up CELTS in Firefox and Chrome
  • Make sure you can select dates for a single event on both Firefox and Chrome
  • Make the event you are creating a multiple offering event
  • Add multiple rows and make sure you can select dates on each of those new rows.

@bledsoef bledsoef self-assigned this Nov 15, 2024
@stevensonmichel
Copy link
Contributor

The time formatting is not quite correct.
Screenshot 2024-11-20 160023

Copy link

github-actions bot commented Dec 3, 2024

View Code Coverage

@bledsoef bledsoef merged commit 3674921 into development Dec 3, 2024
5 checks passed
@bledsoef bledsoef deleted the 1267-timepicker-issue branch December 3, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants