Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with deleting recurring events #1359

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fixed bug with deleting recurring events #1359

merged 2 commits into from
Nov 22, 2024

Conversation

bledsoef
Copy link
Contributor

Issue Description

Fixes #1350

  • When attempting to delete multiple recurring events from a series stuff breaks.

Changes

  • Made sure the only recurring events we were attempting to rename were those that were active and not deleted, as that was causing the problem.

Testing

  • Checkout development
  • Reset database
  • Create a recurring series with 10 events
  • Delete the 5th
  • Delete the 1st
  • The order should get weird now
  • Keep deleting the 1st and verifying weird functionality.
  • Checkout 1350_recurring_events_bug
  • Reset database
  • Repeat steps 3-5 but verify it works now.
  • Rejoice!

@bledsoef bledsoef requested a review from ojmakinde November 22, 2024 20:52
@github-actions GitHub Actions
Copy link

View Code Coverage

Karina-Agliullova
Karina-Agliullova approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Karina-Agliullova Karina-Agliullova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would be nice if UI was changed to make the delete modal look better, but it might be for a separate issue

@bledsoef bledsoef merged commit eaae371 into development Nov 22, 2024
5 checks passed
@bledsoef bledsoef deleted the 1350_recurring_events_bug branch November 22, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karina-Agliullova Karina-Agliullova Karina-Agliullova approved these changes

@Mbeweg Mbeweg Mbeweg approved these changes

@ojmakinde ojmakinde Awaiting requested review from ojmakinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events List Recurring Events break when deleting one of the recurring events
3 participants
@bledsoef @Karina-Agliullova @Mbeweg