Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix to same day multiple time offering #1360

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Conversation

WackyWeaver
Copy link
Contributor

Issue Description

Fixes #1357
If you try to save a multiple event offerings time slot with today's date, even if the time is later than when you are creating it will give you an error like below. I do not believe this is the expected functionality.

Changes

  • I added the start time to the date object in the isDateInPast function

Testing

  • git checkout fixSameDayEvent
  • start to create a multiple time offering

@WackyWeaver WackyWeaver marked this pull request as ready for review December 2, 2024 20:12
Copy link
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 3, 2024

View Code Coverage

@bledsoef bledsoef merged commit eda40bb into development Dec 3, 2024
5 checks passed
@bledsoef bledsoef deleted the fixSameDayEvent branch December 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picking today's date counts as a "past start date" in multiple event offerings
2 participants