Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumb player can't get reward from Vegeir #151

Closed

Conversation

dzmitry-rudnouski
Copy link

Dumb player can complete Jo/Vegeir quest, but can't get reward from Vegeir.
SLOT10.zip

Option in Node003 means that dumb player should get reward:
https://github.com/BGforgeNet/Fallout2_Unofficial_Patch/blob/master/scripts_src/modoc/mcvegeir.ssl#L274,
but he can't jump into Node003 because of missed option in Node001. I've added it and corrected Node999 option also.

@burner1024
Copy link
Member

[DSCD] from other Modoc scripts it seems g_grunt is usually used along side with g_bye as alternative of "bye" for dumb players, better to use other lines (or add a new line, like a simple "[Nod]") to reply Vegeir I guess.

@dzmitry-rudnouski
Copy link
Author

In general I'm ok with "[Nod]".

But Vegeir says: "How good of you to return. I take it you have delivered the message to Modoc, then. How was it
received?"
There is question at the end, so answering with "[Nod]" looks bit strange.

At the same time g_grunt is
# ... generic noises that the player makes when he/she has a low i.q. level. #
https://github.com/BGforgeNet/Fallout2_Unofficial_Patch/blob/master/data/text/english/dialog/generic.msg#L58
and sometimes is used not only in exit node, but also in node that jumps to exit node:
https://github.com/BGforgeNet/Fallout2_Unofficial_Patch/blob/master/scripts_src/modoc/mcprotec.ssl#L196
https://github.com/BGforgeNet/Fallout2_Unofficial_Patch/blob/master/scripts_src/modoc/mcgrisha.ssl#L619

What do you think?

@NovaRain
Copy link

NovaRain commented Nov 8, 2024

Here's my attempt:
NovaRain@4a6a61b

I took the same line from Metzger's dialogue because at least the player makes some affirmative noise with a nod. Would be better to add more context (i.e. make a new msg line, like Uya! Modoc happy! [nod]) to better address Vegeir's question.

@burner1024
Copy link
Member

Any way works for me, do whatever you guys agree on.

@dzmitry-rudnouski
Copy link
Author

Here's my attempt: NovaRain@4a6a61b

Ok, let's use it.

NovaRain added a commit to NovaRain/Fallout2_Unofficial_Patch that referenced this pull request Nov 9, 2024
NovaRain added a commit to NovaRain/Fallout2_Restoration_Project that referenced this pull request Nov 9, 2024
@dzmitry-rudnouski dzmitry-rudnouski deleted the vegeir-reward branch November 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants