Add checks to Unixpath

BIBSYSDEV · Dec 4, 2024 · 07cecad · 07cecad
1 parent ebbd9ad
commit 07cecad
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/core/src/main/java/nva/commons/core/paths/UnixPath.java b/core/src/main/java/nva/commons/core/paths/UnixPath.java
@@ -129,6 +129,9 @@ public boolean isEmptyPath() {
     }
 
     public UnixPath replacePathElementByIndexFromEnd(int index, String replacement) {
+        if (isRoot() || isEmptyPath() || path.size() <= index) {
+            return this;
+        }
         var newPath = new ArrayList<>(path);
         newPath.set(lastPathElementIndex() - index, replacement);
         return new UnixPath(newPath);

diff --git a/core/src/test/java/nva/commons/core/paths/UnixPathTest.java b/core/src/test/java/nva/commons/core/paths/UnixPathTest.java
@@ -283,6 +283,25 @@ void shouldReplacePathElementByIndexFromEnd(int indexFromEnd) {
         assertThat(actualPath, is(equalTo(expectedPath)));
     }
 
+    @Test
+    void shouldReturnEmptyPathWhenReplacingElementByIndexFromEndInEmptyPath() {
+        var actualPath = UnixPath.EMPTY_PATH.replacePathElementByIndexFromEnd(0, "replacement");
+        assertThat(actualPath, is(equalTo(UnixPath.EMPTY_PATH)));
+    }
+
+    @Test
+    void shouldDoNothingWhenReplacingElementByIndexFromEndInRootPath() {
+        var actualPath = UnixPath.ROOT_PATH.replacePathElementByIndexFromEnd(0, "replacement");
+        assertThat(actualPath, is(equalTo(UnixPath.ROOT_PATH)));
+    }
+
+    @Test
+    void shouldDoNothingWhenReplacingIndexThatDoesNotExist() {
+        var originalPath = UnixPath.of("justASingleElement");
+        var actualPath = originalPath.replacePathElementByIndexFromEnd(1, "replacement");
+        assertThat(actualPath, is(equalTo(originalPath)));
+    }
+
     private static class ClassWithUnixPath {
 
         private UnixPath field;