Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-base on top of the latest BDK #9

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

zoedberg
Copy link

This PR is part of a v0.11 fixes epic, see RGB-WG/rgb-tests#30 for an overview.

@zoedberg
Copy link
Author

@dr-orlovsky please enable the CI for this repo

@dr-orlovsky
Copy link
Member

@zoedberg sure, but I do not see a button "enable CI" in github - and do not know how to "enable it"...

@zoedberg
Copy link
Author

I think you need to go to the "Actions" tab, which is between the "Pull requests" tab and the "Projects" one

@dr-orlovsky
Copy link
Member

Ok, thank you. This wasn't about your access rights; it was about the fact that GitHub disables all workflows for the forked repos - and one needs to re-enable them on that page. Wow.

@dr-orlovsky dr-orlovsky changed the title v0.11 fixes Re-base on top of the latest BDK Jan 25, 2025
@dr-orlovsky dr-orlovsky self-assigned this Jan 25, 2025
@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Jan 25, 2025
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for me. The question is whether this breaks rgb crate and bp-wallet crates in the current master branch. If this breaks, we should have 2 PRs in rgb and bp-wallet adopting new API against their v0.11 branch, and do this one also against v0.11 branch.

Otherwise, it is fine to merge this right into the master.

@zoedberg
Copy link
Author

As you can see from the PR in rgb-tests, the commit that updates esplora (RGB-WG/rgb-tests@8c15609) required changes only to bp-esplora-client. Therefore this PR doesn't break any crate and can be merged.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 25f6ea4

@dr-orlovsky dr-orlovsky merged commit cad9b4c into BP-WG:master Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants