Re-base on top of the latest BDK #9
Conversation
|
@dr-orlovsky please enable the CI for this repo |
|
@zoedberg sure, but I do not see a button "enable CI" in github - and do not know how to "enable it"... |
|
I think you need to go to the "Actions" tab, which is between the "Pull requests" tab and the "Projects" one |
|
Ok, thank you. This wasn't about your access rights; it was about the fact that GitHub disables all workflows for the forked repos - and one needs to re-enable them on that page. Wow. |
There was a problem hiding this comment.
This looks good for me. The question is whether this breaks rgb crate and bp-wallet crates in the current master branch. If this breaks, we should have 2 PRs in rgb and bp-wallet adopting new API against their v0.11 branch, and do this one also against v0.11 branch.
Otherwise, it is fine to merge this right into the master.
|
As you can see from the PR in rgb-tests, the commit that updates esplora (RGB-WG/rgb-tests@8c15609) required changes only to bp-esplora-client. Therefore this PR doesn't break any crate and can be merged. |
This PR is part of a v0.11 fixes epic, see RGB-WG/rgb-tests#30 for an overview.