Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework api #18

Merged
merged 2 commits into from
Oct 10, 2024
Merged

rework api #18

merged 2 commits into from
Oct 10, 2024

Conversation

BROngineer
Copy link
Owner

Mostly renaming and restructuring with some API enhancements

Signed-off-by: Artem Bortnikov <[email protected]>
@github-actions github-actions bot added api-change enhancement New feature or request tests labels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
flagset/flagset.go 96.51% 7 Missing and 3 partials ⚠️
flag/parser.go 50.00% 6 Missing ⚠️
parser/parser.go 50.00% 4 Missing ⚠️
flag/generic.go 90.90% 1 Missing and 1 partial ⚠️
flag/bool.go 66.66% 0 Missing and 1 partial ⚠️
flag/duration.go 66.66% 0 Missing and 1 partial ⚠️
flag/durationslice.go 66.66% 0 Missing and 1 partial ⚠️
flag/float32.go 66.66% 0 Missing and 1 partial ⚠️
flag/float32slice.go 66.66% 0 Missing and 1 partial ⚠️
flag/float64.go 66.66% 0 Missing and 1 partial ⚠️
... and 20 more
Files with missing lines Coverage Δ
env/config.go 100.00% <100.00%> (ø)
env/option.go 100.00% <100.00%> (ø)
flag/boolslice.go 65.62% <100.00%> (+6.25%) ⬆️
flag/counter.go 63.63% <100.00%> (ø)
flag/float64slice.go 65.62% <100.00%> (+6.25%) ⬆️
flag/int16slice.go 65.62% <100.00%> (+6.25%) ⬆️
flag/string.go 100.00% <100.00%> (+15.78%) ⬆️
flag/typed.go 100.00% <100.00%> (ø)
flag/value.go 54.16% <100.00%> (ø)
flagset/builder.go 100.00% <100.00%> (ø)
... and 30 more

... and 2 files with indirect coverage changes

Signed-off-by: Artem Bortnikov <[email protected]>
@BROngineer BROngineer merged commit 41638dd into main Oct 10, 2024
5 checks passed
@BROngineer BROngineer deleted the enh/api branch October 10, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant