Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#105 fix: resolve _gezamenlijk gezag_ always missing _derde_ #106

Merged
merged 4 commits into from
Sep 24, 2024
Merged

#105 fix: resolve _gezamenlijk gezag_ always missing _derde_ #106

merged 4 commits into from
Sep 24, 2024

Conversation

FrozenSync
Copy link
Contributor

Fixes #105

@FrozenSync FrozenSync self-assigned this Sep 23, 2024
@FrozenSync
#105 test: update expected test results after `GezamenlijkGezag.derde…
2ecee1a 
…` is fixed
@FrozenSync
#105 refactor(sonar): replace assertTrue with assertEquals
74b1ef8
@FrozenSync
#105 fix: resolve potentially returning unrelated GezamenlijkGezag …
c3f23f6 
…or `Voogdij`

For example, given the following:
- vader (bevraagde persoon)
- kind

when determining gezag of kind, results in:
- GezamenlijkGezag with moeder and derde

then the resulting GezamenlijkGezag should be excluded as it does not contain vader.
@FrozenSync FrozenSync force-pushed the feature/#105-Wanneer-gezamenlijk-gezag-wordt-gegeven,-ontbreekt-altijd-de-derde branch from 2d13df9 to c3f23f6 Compare September 24, 2024 10:03
@FrozenSync FrozenSync merged commit 293bbf4 into main Sep 24, 2024
1 check passed
@FrozenSync FrozenSync deleted the feature/#105-Wanneer-gezamenlijk-gezag-wordt-gegeven,-ontbreekt-altijd-de-derde branch September 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrick-4488 Patrick-4488 Awaiting requested review from Patrick-4488

Assignees

@FrozenSync FrozenSync

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wanneer gezamenlijk gezag wordt gegeven, ontbreekt altijd de derde
1 participant
@FrozenSync