Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experiment pages layout #219

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Update experiment pages layout #219

merged 5 commits into from
Jan 3, 2025

Conversation

LuiggiTenorioK
Copy link
Member

@LuiggiTenorioK LuiggiTenorioK commented Dec 27, 2024

PR to make visual improvements and solve the following issues

Tasks:

  • Add the new upper header info box in the experiment page layout
  • Add a new loading animation (three dots)
  • Keep tree view badges font color
  • Reduce font size of the tree view directory counters
  • Review responsiveness
  • Fix minor visual issues

@LuiggiTenorioK LuiggiTenorioK self-assigned this Dec 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.15%. Comparing base (cfe376a) to head (468af0d).

Files with missing lines Patch % Lines
src/common/ExperimentInfoHeader.jsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   71.06%   71.15%   +0.08%     
==========================================
  Files          53       55       +2     
  Lines        1552     1560       +8     
  Branches      193      193              
==========================================
+ Hits         1103     1110       +7     
- Misses        340      341       +1     
  Partials      109      109              
Flag Coverage Δ
fast-tests 71.15% <88.88%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK
Copy link
Member Author

LuiggiTenorioK commented Dec 27, 2024

How the new upper bar looks:

image

(Zoom if necessary)

@kinow
Copy link
Member

kinow commented Dec 30, 2024

How the new upper bar looks:

It looks similar to what I see currently in a Quick View for a DestinE experiment, but maybe the difference here is that that will be now visible in every view (graph/tree)?

@LuiggiTenorioK
Copy link
Member Author

How the new upper bar looks:

It looks similar to what I see currently in a Quick View for a DestinE experiment, but maybe the difference here is that that will be now visible in every view (graph/tree)?

Yes. Also, it has the "running" indicator on its left side.

@LuiggiTenorioK LuiggiTenorioK merged commit 83938ce into master Jan 3, 2025
4 checks passed
@LuiggiTenorioK LuiggiTenorioK deleted the update-exp-layout branch January 3, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants