You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today @orioltinto had a question about some job variables not being correctly translated as he expected them to be. I had a look, and checked our docs first. If a user searches by --cpus-per-task, they find two hits, one being this one.
I tried the NUMTHREADS but it didn't work as expected. A quick debugging in the IDE, and found that I needed to use THREADS instead. It's not clear (or I don't remember) why we have threads/numthreads, but if one is deprecated or not used, then I guess it'd be better to remove it from the docs and warn the users to update their configs.
The text was updated successfully, but these errors were encountered:
From what I understood by checking the code, in the job.py file in the line 485 all the 3 call should do the same thing setting the value of threads as image bellow
Around the line 1550, the NUMTHREADS will preserve all values inside the THREADS in case of a list or just 1 value in a scheduler process while THREADS only keeps its highest value
When updating the parameters of a platform all values are set the same as THREADS num
THREADS are used as well in Many different places both as .threads | ._threads to set the experiment and or wrapper
On the other hand NUMTHREADS is only used in the pjm_header, job and slurm_header which is a instance of the job class which makes it essentially the same as the THREAD
So I believe that there´s a mismatch and/or a confusion regarding the use of this two arguments, which may at some point have been treated as interchangeable and they were supposed to represent different behaviors in the system leading to the situation we are currently facing, or they were always meant to be similar instruction and at some point they became different instructions.
I too believe their behavior should be always the same no matter if you're using NUMTHREADS, THREADS, or CPU_PER_TASK, I couldn't find instances where
To add a bit more of context @manuel-g-castro and I done a few test on the AS3.15 and the problem presented itself, I was analyzing the AS4, I still need to do a double check on the AS3 code to make sure there´s a difference between them or if I missed something during my investigation
Today @orioltinto had a question about some job variables not being correctly translated as he expected them to be. I had a look, and checked our docs first. If a user searches by
--cpus-per-task
, they find two hits, one being this one.I tried the
NUMTHREADS
but it didn't work as expected. A quick debugging in the IDE, and found that I needed to useTHREADS
instead. It's not clear (or I don't remember) why we have threads/numthreads, but if one is deprecated or not used, then I guess it'd be better to remove it from the docs and warn the users to update their configs.The text was updated successfully, but these errors were encountered: