Refactor commands #14
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix permission checks when sender is not the target. Prepare to make it work with any entity. Send messages asynchronously. Code cleanup.
SmylerMC
force-pushed
the
refactor/commands
branch
from
da4233b to
776dc5c
Compare
Remove unnecessary command name check. Get the projection from the world generator. Send a proper error message when out of projection bounds. Do not use deprecated HoverEvent(Action, TextComponent) constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor command code to better match Terra++, take better advantage of Terra--, the Bukkit API, and other general code cleanup.
Changes so far
/offset./tpll./where./tpll, giving it the same capabilities as Terra++.This PR is not ready, I'll un-draft it when it is.