Refactor LCM Module to Remove Configuration Reliance #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephoris
added a commit
that referenced
this pull request
Feb 1, 2024
* [Refactor] Remove policies in sample design * [Refactor] Remove dead comments * [Refactor] Remove EndureCost reliance on config * [Refactor] Remove LCMDataGen reliance on config * [Refactor] Remove LCMModelBuilder reliance on config * [Refactor] Remove LCMEvalUtil reliance on config * [Refactor] Removal of QModelMultiHead
ephoris
added a commit
that referenced
this pull request
Apr 23, 2024
* [Refactor] Remove policies in sample design * [Refactor] Remove dead comments * [Refactor] Remove EndureCost reliance on config * [Refactor] Remove LCMDataGen reliance on config * [Refactor] Remove LCMModelBuilder reliance on config * [Refactor] Remove LCMEvalUtil reliance on config * [Refactor] Removal of QModelMultiHead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Context
We (100% really just me) should have built flexible modules first, then utilize those modules to strict jobs. Now that we have been moving to creating new jobs, such as the hyper parameter tuning and the bayseian optimizer we will need to fix my design errors.
Major Changes
LCMDataGeneratorobjects now do not require the configuration object for initializationLearnedCostModelBuilderobjects now do not require the configuration objectLCMEvalUtilobjects now do not require the configuration object