Developer friendly rework #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because more folks are contributing to this, I'm making an effort to make the templating system I set up better and clearer.
Previously, I wrote code in header.py and footer.py files and copied these to create the library snirf/pysnirf2.py... this was a redundant and unclear design. Now, edits to the library file itself are valid AS LONG AS THEY DO NOT FALL WITHIN THE CENTRAL PORTION OF THE CODE. This section is still supposed to be generated from the jinja template.
This part of the code is clearly marked, and is largely implementations of the classes laid out above. Special cases are implemented via overrides below this part.
Also includes a quick fix to #38