Dockerize #11
Merged
Dockerize #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5 and python3.5. Version differences here may not be worth the effort it takes to install the latest releases, but /shrug
…ded arg parse to server.py so you can specify host
…3.5 With the production setup script, the run command passes your current ROS_MASTER_URI to the docker image
…art the ingestor now and its good to gooooo
…ts in docker. Unfortunately connecting to a local ros network is a bit difficult due to dockers networking setup... On linux its pretty easy tho
…nces of running in non-linux env
|
I'm calling this 'good enough' for now. Basically on Linux it works (I'm pretty sure), and is able to connect to an external ROS network. This may see more evolution as we continue building out the server. Especially with whatever ends up happening with interop submission.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coincides with #9
Allows deployment of the entire server code base as a docker container. This includes running of both the ros_ingester and the main server.
Discussion: does starting container give you a fresh database. do we want to retain back history unless manually cleared by someone?