Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #66

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
4e0929b
pins have a have name
joamatab May 15, 2022
cde8a68
pin repr returns a string
joamatab May 15, 2022
4f4523b
clean code with sourcery
joamatab May 15, 2022
e7f74e0
improve docstrings
joamatab May 15, 2022
52f4928
Merge branch 'master' into improvements
SkandanC Aug 25, 2022
ac0e2fa
Update tox.ini
SkandanC Oct 26, 2022
c65a308
Update tox.ini
SkandanC Oct 26, 2022
5e98f2e
Update tox.ini
SkandanC Oct 26, 2022
4f0641d
Final commit to fix... hopefully
SkandanC Oct 26, 2022
26f8372
Update build-and-test.yml
SkandanC Oct 26, 2022
e8f9027
Update build-and-test.yml
SkandanC Oct 26, 2022
dda82d5
Update
SkandanC Oct 26, 2022
1a6b5a5
Swap conditions
SkandanC Oct 26, 2022
2b77ef4
Fix tests
SkandanC Oct 26, 2022
dfe1555
Update test_simulation.py
SkandanC Oct 26, 2022
980873f
Update test_simulation.py
SkandanC Oct 26, 2022
dff72db
Add python version specific dependencies
SkandanC Oct 26, 2022
ac09341
Update tox.ini
SkandanC Oct 26, 2022
d2d58d4
Update
SkandanC Oct 26, 2022
4ed0354
Update build-and-test.yml
SkandanC Oct 26, 2022
fd1a72b
Fix version and test
SkandanC Oct 26, 2022
de104ce
update tp 3.11
SkandanC Oct 26, 2022
855d9eb
Update tox.ini
SkandanC Oct 27, 2022
e07d61a
Merge remote-tracking branch 'upstream/master' into pr/66
SkandanC Oct 27, 2022
35739af
Merge branch 'add-3.11-to-workflows' into pr/66
SkandanC Oct 27, 2022
ade8a01
Revert "Merge branch 'add-3.11-to-workflows' into pr/66"
SkandanC Oct 27, 2022
037927f
Revert "Merge remote-tracking branch 'upstream/master' into pr/66"
SkandanC Oct 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ jobs:
build:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v1
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand All @@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11.0']
python-version: ['3.7', '3.8', '3.9', '3.10']
name: build and test
on:
pull_request:
Expand Down
2 changes: 2 additions & 0 deletions .sourcery.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
refactor:
python_version: '3.7'
20 changes: 0 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,3 @@ The documentation is hosted [online](https://simphonyphotonics.readthedocs.io/en

Changelogs can be found in docs/changelog/. There is a changelog file for
each released version of the software.

## Bibtex citation

```
@article{DBLP:journals/corr/abs-2009-05146,
author = {Sequoia Ploeg and
Hyrum Gunther and
Ryan M. Camacho},
title = {Simphony: An open-source photonic integrated circuit simulation framework},
journal = {CoRR},
volume = {abs/2009.05146},
year = {2020},
url = {https://arxiv.org/abs/2009.05146},
eprinttype = {arXiv},
eprint = {2009.05146},
timestamp = {Thu, 17 Sep 2020 12:49:52 +0200},
biburl = {https://dblp.org/rec/journals/corr/abs-2009-05146.bib},
bibsource = {dblp computer science bibliography, https://dblp.org}
}
```
1 change: 0 additions & 1 deletion docs/source/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ accessible through the sidebar navigation.
tutorials/intro
tutorials/mzi
tutorials/filters
tutorials/layout_aware

.. toctree::
:hidden:
Expand Down
5 changes: 0 additions & 5 deletions docs/source/reference/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ API
:inherited-members:
:show-inheritance:

.. automodule:: simphony.die
:members:
:inherited-members:
:show-inheritance:

.. automodule:: simphony.formatters
:members:
:inherited-members:
Expand Down
Binary file removed docs/source/tutorials/images/layout_aware.png
Binary file not shown.
Binary file removed docs/source/tutorials/images/mzi_layout_aware.png
Binary file not shown.
4 changes: 2 additions & 2 deletions docs/source/tutorials/intro.rst
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ order to preserve the original circuit.
Let's run a simple sweep simulation on the circuit we have
created: ::

from simphony.simulators import SweepSimulator
simulation = SweepSimulator(1500e-9, 1600e-9)
from simphony.simulators import SweepSimulation
simulation = SweepSimulation(1500e-9, 1600e-9)
simulation.multiconnect(component1['input'], component2['pin2'])
result = simulation.simulate()

Expand Down
172 changes: 0 additions & 172 deletions docs/source/tutorials/layout_aware.rst

This file was deleted.

2 changes: 1 addition & 1 deletion examples/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#
# File: filters.py

import matplotlib.gridspec as gridspec
import matplotlib.pyplot as plt
import matplotlib.gridspec as gridspec

from simphony.libraries import siepic, sipann
from simphony.simulators import SweepSimulator
Expand Down
115 changes: 0 additions & 115 deletions examples/layout_aware.py

This file was deleted.

1 change: 1 addition & 0 deletions examples/mzi.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# (see simphony/__init__.py for details)

import matplotlib.pyplot as plt
import numpy as np

from simphony.libraries import siepic
from simphony.simulation import Detector, Laser, Simulation
Expand Down
1 change: 0 additions & 1 deletion examples/subnetwork_growth.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@

import matplotlib.pyplot as plt
import numpy as np

from simphony.connect import connect_s, innerconnect_s
from simphony.libraries import siepic, sipann
from simphony.tools import wl2freq
Expand Down
Loading