Collections #1
Open
Collections #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BabisK
commented
Jun 17, 2020
longclaw/checkout/utils.py
Outdated
| @@ -23,6 +25,17 @@ def create_order(email, | |||
| Create an order from a basket and customer infomation | |||
| """ | |||
| basket_items, current_basket_id = get_basket_items(request) | |||
|
|
|||
| if not len(basket_items) > 0: | |||
There was a problem hiding this comment.
This looks like you're trying to solve a different problem. If this is the case, open an issue on the upstream and create a fork to solve it. Let's not mesh the issues.
longclaw/checkout/api.py
Outdated
| addresses=address, | ||
| shipping_option=shipping_option, | ||
| ) | ||
| try: |
There was a problem hiding this comment.
See comment on utils.py bellow
|
Also remind me why we need the update from wagtail 2.6 to 2.9 |
BabisK
force-pushed
the
collections
branch
2 times, most recently
from
2a7aae0 to
8d1e999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.