Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer : Extendable render #16119

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Conversation

ffaure
Copy link
Contributor

@ffaure ffaure commented Jan 28, 2025

This PR removes features specific to the Babylon Viewer, such as the progress bar and toolbar, making them more easily customizable. Instead of being tightly coupled to the core implementation, these elements can now be modified by extending ViewerElement and overriding the extendRender method.

By following this approach, we avoid the need to fully rewrite the render method, which is responsible for rendering the viewer and managing child elements via the designated slot.

Changes

  • Removed hardcoded progress bar and toolbar from the Babylon Viewer.
  • Introduced an extension-based approach via extendRender in ViewerElement.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@ffaure ffaure force-pushed the extended-renderer branch from cfa48d3 to 52b4088 Compare January 28, 2025 16:46
@ffaure ffaure marked this pull request as draft January 28, 2025 16:47
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@ffaure ffaure closed this Jan 28, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@ffaure ffaure changed the title Extendable rendering in ViewerElement Viewer : Extendable render Jan 29, 2025
@ffaure ffaure reopened this Jan 29, 2025
@ffaure ffaure marked this pull request as ready for review January 29, 2025 14:59
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 29, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 29, 2025

@sebavan sebavan requested a review from ryantrem January 29, 2025 18:03
Moving tool bar ui to `renderToolbar`, progress bar to `renderProgressBar` and renaming `extendRender` to `renderOverlay` that is responsible of all UI overlay.
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

ffaure and others added 2 commits January 31, 2025 10:37
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
Keeping naming convention on renderX methods
_viewerDetails going back to private
Reapplying original code for step input
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

@ryantrem ryantrem enabled auto-merge (squash) January 31, 2025 16:42
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

@ryantrem ryantrem merged commit 7136688 into BabylonJS:master Jan 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants