-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer : Extendable render #16119
Viewer : Extendable render #16119
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
cfa48d3
to
52b4088
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16119/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16119/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16119/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
Moving tool bar ui to `renderToolbar`, progress bar to `renderProgressBar` and renaming `extendRender` to `renderOverlay` that is responsible of all UI overlay.
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
Keeping naming convention on renderX methods _viewerDetails going back to private Reapplying original code for step input
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
This PR removes features specific to the Babylon Viewer, such as the progress bar and toolbar, making them more easily customizable. Instead of being tightly coupled to the core implementation, these elements can now be modified by extending
ViewerElement
and overriding theextendRender
method.By following this approach, we avoid the need to fully rewrite the render method, which is responsible for rendering the viewer and managing child elements via the designated slot.
Changes
extendRender
inViewerElement
.