-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenGL external texture support #1439
base: master
Are you sure you want to change the base?
Conversation
@kmatzen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We unfortunately do not have testing for this class yet. I'm assuming this code works in your scenario?
I started with the ExternalTexture for Metal and had an LLM convert it to OpenGL. I fixed up a few parts where it made mistakes in the texture enums, then eyeballed the rest.