Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with more recent Java and Node versions #640

Closed
wants to merge 15 commits into from

Conversation

CedricGuillemet
Copy link
Contributor

No description provided.

@matthargett
Copy link

landing RNTA updated to nodejs 18, so maybe this just needs a rebase?

@CedricGuillemet
Copy link
Contributor Author

Got this build error with RN 0.64:

Script '/Users/runner/work/BabylonReactNative/BabylonReactNative/Apps/Playground/0.64/node_modules/react-native/react.gradle' line: 300

* What went wrong:
A problem occurred configuring project ':app'.
> Could not create task ':app:copyDebugBundledJs'.
   > Could not create task ':app:mergeDebugAssets'.
      > Cannot use @TaskAction annotation on method IncrementalTask.taskAction$gradle_core() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method.

RN 0.64 gradle build script is deprecated. tasks.whenTaskAdded must be replaced with tasks.configureEach. So, it's not possible to update Java until RN 0.64 is being used by the build.

@CedricGuillemet
Copy link
Contributor Author

CedricGuillemet commented May 29, 2024

Another test using RN 0.69 instead of 0.64 for PR build and got this error with Windows build:

RNPermissions.vcxproj(160,5): error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is D:\a\BabylonReactNative\BabylonReactNative\Apps\Playground\Playground\windows\\packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.props.

This issue was fixed in RNPermissions when working on RNTA and [email protected] was released. 4.1.5 needs [email protected] which makes it incompatible with RN 0.69 because of a dependency to [email protected].

This didn't happen with 0.64 because cppwinrt version was the same between RNPermissions and RN

Envisaged solutions:

  • use PR build to use Playground 0.70 or 0.71 and deprecate 0.69 as well
  • use PR build to use Playground 0.70 or 0.71 but keep 0.69 (might see issues only when publishing)
  • use RNTA with RN 0.69 (might see same issue) or later

@tido64
Copy link
Contributor

tido64 commented May 30, 2024

If I'm not mistaken, the reason you're seeing that error is because the .vcxproj has not been updated to use package references introduced in RNW 0.68. Removing the checks at the bottom of the project file (for reference, see zoontek/react-native-permissions#860) should let you build and can be done with patch-package. It's another solution if you're fine with patching RNPermissions.

 into node18java18

# Conflicts:
#	.github/workflows/bn_master_commit.yml
#	.github/workflows/ios_android.yml
#	.github/workflows/pr.yml
@CedricGuillemet
Copy link
Contributor Author

Closing for #647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants