Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation guidance and silence typechecking #62

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

asullivan-blze
Copy link
Contributor

Relates to PR #61.

What and why?

While I'd like to eventually get this into Poetry to allow for isolated development, at least isolating this via pipx so it doesn't lead to dependency chaos for system/user packages should be what we recommend. (And it's how I have my copy of ansible and boardwalk installed locally.)

Additionally, resolves the issue from some change in Pyright now triggering a failure over in PR #61.

/home/runner/work/boardwalk/boardwalk/src/boardwalk/manifest.py
  /home/runner/work/boardwalk/boardwalk/src/boardwalk/manifest.py:139:17 - error: Expression of type "tuple[tuple[str]]" cannot be assigned to declared type "tuple[str]"
    "tuple[str]" is incompatible with "str" (reportAssignmentType)
1 error, 0 warnings, 0 informations 
make: *** [Makefile:83: test-pyright] Error 1
Error: Process completed with exit code 2.

How was this tested?

make test; no errors.

Copy link
Member

@metadaddy metadaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, especially the blank lines before function definitions. Gotta love linting tools! ;-)

@asullivan-blze asullivan-blze merged commit b42a976 into main Feb 15, 2024
1 check passed
@asullivan-blze asullivan-blze deleted the readme-and-typechecking-silencing branch February 15, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants