Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions on submitting a pull request #82

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add instructions on submitting a pull request #82

merged 1 commit into from
Aug 21, 2024

Conversation

metadaddy
Copy link
Member

Preparation for open source launch.

asullivan-blze
asullivan-blze requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@asullivan-blze asullivan-blze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue that needs to be fixed, namely the URI on fork; the suggestion in the comment is to the GitHub docs on how to fork a repo.

asullivan-blze
asullivan-blze reviewed Aug 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@metadaddy
Copy link
Member Author

One issue that needs to be fixed, namely the URI on fork; the suggestion in the comment is to the GitHub docs on how to fork a repo.

Suggestion accepted. Thanks!

asullivan-blze
asullivan-blze previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@asullivan-blze asullivan-blze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metadaddy metadaddy force-pushed the add-pull-request-to-contributing branch 2 times, most recently from 4afcc61 to e8d48d9 Compare August 21, 2024 18:03
asullivan-blze
asullivan-blze approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@asullivan-blze asullivan-blze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metadaddy metadaddy force-pushed the add-pull-request-to-contributing branch 2 times, most recently from c832476 to 6218880 Compare August 21, 2024 18:27
@metadaddy metadaddy force-pushed the add-pull-request-to-contributing branch from 6218880 to f3c6ece Compare August 21, 2024 18:35
@metadaddy metadaddy merged commit 643085e into main Aug 21, 2024
2 checks passed
@metadaddy metadaddy deleted the add-pull-request-to-contributing branch August 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asullivan-blze asullivan-blze asullivan-blze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metadaddy @asullivan-blze