Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make appName and key always lowercase to match how subdomains are always lowercase #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nsmith7989
Copy link

I ran into this issue when I was trying to dockerize this. Here's what happened:

Our branch names generally contain a jira issue id which contains capital letters. Something like: NHCRES-123.

If I use the subdomain package resolver this would result in a url like http://NHCRES-123.myapp.backstage-server.com, which most browsers change to http://nhcres-123.myapp.backstage-server.com. If this server is running on a case sensitive file system then package is not found.

IMO it is a nicer default to always convert package name (key) and app name to lowercase to solve this issue.

@jessepinho
Copy link
Collaborator

Thanks for the PR, @nsmith7989 ! Just saw it, so sorry for the delay. Will take a look in the next few days :)

@jessepinho
Copy link
Collaborator

@nsmith7989 Well, clearly I never got back to this 😆 Have you tested your branch and it works? If so, could you please just push up a commit that reverts the tsconfig.json changes in this PR, since it looks like they're just formatting changes? Then I'll merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants