-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get full core pools json directly from bal tools #588
Conversation
Did sanity check of v3 pools. Can simply use this view and check if all with 50% boosted or YB are tracked. IMO following pool should also be core but didn't get added: https://balancer.fi/pools/ethereum/v3/0x5512fddc40842b257e2a7742be3dadcf31574d53 For that one the weight distribution is shifted to pxETH but still this one should be core as it is a boosted pool |
it wasnt added to the vebal controller yet. since that is now executed, we can run this action again and confirm it now gets added |
Small incremental changes here OK. Checklist dune query reference correct |
whitelisted eclp pools as per BalancerMaxis/bal_tools#82 (comment) |
whitelisted pools wont be added until whitelist json is in main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- found 2 incorrectly set pools in whitelist. need to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, all changes g2g 🎉
test run for BalancerMaxis/bal_tools#73