Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get full core pools json directly from bal tools #588

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

gosuto-inzasheru
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru commented Jan 28, 2025

@Xeonus
Copy link
Contributor

Xeonus commented Jan 28, 2025

Did sanity check of v3 pools. Can simply use this view and check if all with 50% boosted or YB are tracked.

IMO following pool should also be core but didn't get added: https://balancer.fi/pools/ethereum/v3/0x5512fddc40842b257e2a7742be3dadcf31574d53

For that one the weight distribution is shifted to pxETH but still this one should be core as it is a boosted pool

@gosuto-inzasheru
Copy link
Collaborator Author

it wasnt added to the vebal controller yet. since that is now executed, we can run this action again and confirm it now gets added

@gosuto-inzasheru
Copy link
Collaborator Author

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review January 29, 2025 12:23
@Xeonus
Copy link
Contributor

Xeonus commented Feb 7, 2025

Small incremental changes here OK. Checklist dune query reference correct

@gosuto-inzasheru
Copy link
Collaborator Author

whitelisted eclp pools as per BalancerMaxis/bal_tools#82 (comment)

@gosuto-inzasheru
Copy link
Collaborator Author

whitelisted pools wont be added until whitelist json is in main branch

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review February 7, 2025 08:29
Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • found 2 incorrectly set pools in whitelist. need to be removed

Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, all changes g2g 🎉

@gosuto-inzasheru gosuto-inzasheru merged commit df45368 into main Feb 7, 2025
5 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the feat/use-new-build-core-pools-feature branch February 7, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants