fix: reprio subgraph url sources #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gosuto-inzasheru
commented
Sep 24, 2024
•
gosuto-inzasheru
commented
- fixes outdated subgraph urls by prioritising sdk over frontendv2 as a url source
gosuto-inzasheru
changed the title
Tritium-VLK
reviewed
Sep 25, 2024
| @@ -18,7 +18,6 @@ query LiquidPoolsProtocolYieldFee { | |||
| { poolTypeVersion: 1 } | |||
| ] | |||
| } | |||
| { poolType_contains_nocase: "Gyro" } | |||
There was a problem hiding this comment.
Is this saying that any Gyro pool charges a yield fee?
There was a problem hiding this comment.
this was the assumption in the old query, yes.
by removing the gyro just falls back into the first or case, meaning it needs to have a yield fee > 0 just like the rest
There was a problem hiding this comment.
waiting for clarity from data team, reverted this commit for now
This reverts commit 2b99af5.
gosuto-inzasheru
changed the title
Tritium-VLK
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.