snapshot ecosystem, subgraph methods from fee allocator #9
Conversation
| ) | ||
| return [Pool(**pool) for pool in res["veBalGetVotingList"]] | ||
|
|
||
| def get_balancer_pool_snapshots( |
There was a problem hiding this comment.
still using the traditional endpoints for this, see: #4 (comment)
There was a problem hiding this comment.
Loooks pretty good to me. Before I just stamp it. Posted a few comments.
I didn't do a lot of review of new functions/code/gql files, nor tests. I assume that we can hash this out once we start using it a bit, and we are still in early versions of bal_tools. What's important is that we don't break anything, or notice/change it fast if/when we do.
| @@ -115,3 +120,82 @@ def get_aura_pid_from_gauge(self, deposit_gauge_address: str) -> int: | |||
| f"Got a list result with something other than 1 member when compiling aura PID mapping: {result}" | |||
| ) | |||
| return result[0] | |||
|
|
|||
There was a problem hiding this comment.
I did not review this file in detail but it is not in operation anywhere yet so we will see how it works
| blocks( | ||
| first: 1 | ||
| orderBy: number | ||
| orderDirection: asc | ||
| where: { timestamp_gt: $timestamp } | ||
| where: { timestamp_gt: $timestamp_gt, timestamp_lt: $timestamp_lt} |
There was a problem hiding this comment.
Are you sure nothing is using this yet and passing only GT?
There was a problem hiding this comment.
not sure where else its used outside of this/fee allocator currently. this query is called from get_first_block_after_utc_timestamp, so should be implied that its gt
bal_tools/requirements.txt
Outdated
| @@ -5,5 +5,6 @@ web3 | |||
| dotmap | |||
| munch==4.0.0 | |||
| gql[requests] | |||
| dacite | |||
|
|
|||
| git+https://github.com/BalancerMaxis/[email protected] | |||
There was a problem hiding this comment.
migrated to pydantic: c30415a
bal_tools/subgraph.py
Outdated
| if chain == "optimism": | ||
| return "https://api.thegraph.com/subgraphs/name/iliaazhel/optimism-blocklytics" | ||
| elif chain == "gnosis-chain": |
There was a problem hiding this comment.
A little unclear why you moved it and unsure of this ordering, can you explain?
There was a problem hiding this comment.
wdym ordering? i dont think it should matter here
fix: break loop if urls object ended
#3 #4