Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert division by 2 assumption of previous commits to resolve scribeocr issue 40 #3

Open
wants to merge 1 commit into
base: scribeocr
Choose a base branch
from

Conversation

rmast
Copy link

@rmast rmast commented Aug 9, 2024

@Balearica
Copy link
Owner

Any change to the grid size is going to cause a non-zero number of errors, and solve a non-zero number of errors. Indeed, this change was made because it fixed errors that occurred for other documents. On conceptual grounds, and based on previous documents, I currently believe that using the smaller grid size for noise removal is a net positive.

However, I could always be wrong. Ultimately, this type of question is currently unanswerable given that all we have are individual examples. To make an educated decision on questions of this nature, the impact would need to be quantified using an automated benchmark tool that tests accuracy against a (relatively) large and diverse corpus of documents. Most of the code for this already exists, so it would be a matter of building a diverse corpus of images and ground truth data.

@rmast
Copy link
Author

rmast commented Sep 2, 2024 via email

@Balearica
Copy link
Owner

@rmast I created a benchmark repo here that contains an initial set of 23 diverse images and ground truth data, along with code for running comparisons against OCR results. The initial results are in the README. I plan to use this as a baseline when assessing future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants