Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy bankless.community to cloudflare pages #26

Closed

Conversation

MantisClone
Copy link
Contributor

@MantisClone MantisClone commented Oct 5, 2023

Purpose

This PR deploys the BanklessDAO Website to Cloudflare Pages.

Changes

@MantisClone MantisClone marked this pull request as ready for review October 5, 2023 14:03
@MantisClone MantisClone requested a review from a team as a code owner October 5, 2023 14:03
Copy link
Contributor

@mklebrasseur mklebrasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements

  • Rotate Secrets
  • Replace Secrets with Sensitive Variables
  • Add Secrets to Bitwarden
  • Add Secrets to Terraform Cloud

Copy link
Contributor

@BogDrakonov BogDrakonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to delete and rotate the secrets committed. This is a public repo, but this is bad practice even in private repos.

As @mklebrasseur said

Secrets should not be provided in the repo, they should be placed within the BanklessDAO Bitwarden and then InfoSec will add them as secret ENV's. You can reference them in this project as variables and expect that Terraform Cloud will fill them in.

Example
variable "alchemy_api_key" { sensitive = true }

README.md Show resolved Hide resolved
bankless-community/cloudflare/pages.tf Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@MantisClone
Copy link
Contributor Author

MantisClone commented Oct 9, 2023

@BogDrakonov @mklebrasseur
I rotated the API keys and added them to Bitwarden. Please re-review this PR.

For now, the API keys are associated with my personal accounts - to solve the current API key leak.

In the future, I think it would be appropriate to create dedicated BanklessDAO accounts and generate the API keys from them instead of my personal accounts. The credentials for these dedicated accounts could be stored in Bitwarden and shared as needed.

image

@MantisClone
Copy link
Contributor Author

Hello @BogDrakonov @mklebrasseur How'd it go? Have you successfully added the secrets to the Terraform cloud?

@mklebrasseur
Copy link
Contributor

Hello @BogDrakonov @mklebrasseur How'd it go? Have you successfully added the secrets to the Terraform cloud?

Completed, requested the move of the variables to the variables file. Other than that it's good to go!

mklebrasseur
mklebrasseur previously approved these changes Oct 17, 2023
@MantisClone
Copy link
Contributor Author

@BogDrakonov I'd like to get this deployed and the domain switched over before the end of October so I don't need to seek reimbursement for Vercel hosting in November.

@BogDrakonov
Copy link
Contributor

I'm sorry we didn't catch this earlier, but do you mind opening a PR as a feature branch on this repo? Opening a PR from an external repo doesn't trigger a Terraform plan so we can't validate the result and merge it. Do you mind opening a PR from within this repo? All BanklessDAO GH members have write access to the repo

@MantisClone
Copy link
Contributor Author

Superseded by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants