forked from CleverNucleus/data-attributes
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0+1.20.1-alpha.1-fabric #13
Merged
bibi-reden
merged 72 commits into
BareMinimumStudios:1.20.1/fabric
from
bibi-reden:1.20.1/fabric
Jun 28, 2024
Merged
2.0.0+1.20.1-alpha.1-fabric #13
bibi-reden
merged 72 commits into
BareMinimumStudios:1.20.1/fabric
from
bibi-reden:1.20.1/fabric
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bibi-reden
added
👍 GoodFirstIssue
Good for newcomers
✨ Enhancement
New feature or request
🆘 Help!
Extra attention is needed
📃 Documentation
Improvements or additions to documentation
labels
May 16, 2024
I might just be stupid, ill look at it next week :P
`instances` located in the `DefaultAttributeContainer` has certain entities not having specific attributes. This in turn, causes an `IllegalArgumentException`, and fails to load the world. An ongoing investigation is still happening.
This is just a notice not to utilize this until a major issue is resolved. It's a draft anyway... |
Implements a registry that is not complete, and also adds in some basic data along with their codecs, improved documentation. Cleared out unneeded fields/entries.
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📃 Documentation
Improvements or additions to documentation
✨ Enhancement
New feature or request
👍 GoodFirstIssue
Good for newcomers
🆘 Help!
Extra attention is needed
ℹ️ Information
Further information is requested
🔎 Investigating
The issue/pr is being investigated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR that gets us to 2.0.0+1.20.1 on fabric/quilt.
This will take quite the amount of time, we will draft this for now.