Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] #3

Merged
merged 3 commits into from
Nov 7, 2024
Merged

[CI/CD] #3

merged 3 commits into from
Nov 7, 2024

Conversation

MaciejBinczarowski
Copy link
Collaborator

-added CICD for react module
-test and deploy jobs are empty because of some issues

@MaciejBinczarowski MaciejBinczarowski force-pushed the feature/add-CI-CD-to-react-module branch 2 times, most recently from e684cd7 to 25655f6 Compare November 5, 2024 19:43
@Bart3kTK
Copy link
Owner

Bart3kTK commented Nov 5, 2024

Zrób proszę rebase aby uniknąć dupa commitów na main branchu. Na przykład na dwa - jedno dotyczące poprawek, a drugie dotyczaące CI/CD.

@MaciejBinczarowski MaciejBinczarowski force-pushed the feature/add-CI-CD-to-react-module branch 8 times, most recently from 8076f3a to df49934 Compare November 6, 2024 09:16
@MaciejBinczarowski
Copy link
Collaborator Author

Masz to jak w Bartek!
Wszystko będzie zrebasowane i zesquasowane!

@MaciejBinczarowski MaciejBinczarowski force-pushed the feature/add-CI-CD-to-react-module branch from df49934 to a775f12 Compare November 6, 2024 09:24
 -added rules to prettier formater
 -added required dependencies
 -added scripts to package.json
 -from now you can use npm run format and npm run format check
-added CICD for react module
-test and deploy jobs are empty because of some issues
@MaciejBinczarowski MaciejBinczarowski force-pushed the feature/add-CI-CD-to-react-module branch from a775f12 to 16c5c76 Compare November 6, 2024 17:19
@Bart3kTK
Copy link
Owner

Bart3kTK commented Nov 6, 2024

Kod wygląda należycie, aż sam muszę się zainspirować jobami bo mam prawie dobrze a tu są jak trzeba, wrzuciłbym na merge ale format check się wywalił

@MaciejBinczarowski MaciejBinczarowski force-pushed the feature/add-CI-CD-to-react-module branch from 23bcea3 to 7c6f3cd Compare November 7, 2024 16:19
@Bart3kTK
Copy link
Owner

Bart3kTK commented Nov 7, 2024

Jest git

@Bart3kTK Bart3kTK closed this Nov 7, 2024
@Bart3kTK Bart3kTK reopened this Nov 7, 2024
Copy link
Owner

@Bart3kTK Bart3kTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jet gitesik

@Bart3kTK Bart3kTK merged commit 9a52395 into main Nov 7, 2024
8 checks passed
@MaciejBinczarowski
Copy link
Collaborator Author

bawiłem się rebasowaniem, żeby usunąć niepotrzbne commity. Teraz powinno być git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants