Faciliter la récupération de token #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
J'aurais mis les 2 différents fonctionnalité dans 2 PRs différentes si c'est encore possible ;) |
MaGOs92
force-pushed
the
gfay_feat_retrieve-bal-token
branch
2 times, most recently
from
ab45081 to
ea5f411
Compare
MaGOs92
force-pushed
the
gfay_feat_retrieve-bal-token
branch
2 times, most recently
from
ab5d3b7 to
74c8ce7
Compare
fufeck
approved these changes
Oct 23, 2023
pages/bal/[balId]/index.tsx
Outdated
Comment on lines
113
to
125
| addButton={<Pane marginLeft='auto'> | ||
| <Button | ||
| iconBefore={AddIcon} | ||
| iconBefore={token ? AddIcon : LockIcon} | ||
| appearance='primary' | ||
| intent='success' | ||
| disabled={isEditing} | ||
| disabled={token && isEditing} | ||
| onClick={() => { | ||
| setIsFormOpen(true) | ||
| if (token) { | ||
| setIsFormOpen(true) | ||
| } else { | ||
| setIsRecoveryDisplayed(true) | ||
| } | ||
| }} |
There was a problem hiding this comment.
Je ne suis pas très fan de passer le addButton a VoieList et ToponymeList, c'est du détails, mais je ne comprends pas pourquoi on fait comme ca ici ?? et que cela nuis a la lisibilité, ca fait beaucoup de logique imbriquée
There was a problem hiding this comment.
Oui je suis d'accord, je refacto ça pour mettre le bouton directement dans VoieList et ToponymeList
Done! |
MaGOs92
force-pushed
the
gfay_feat_retrieve-bal-token
branch
from
74c8ce7 to
5c8a2e7
Compare
MaGOs92
force-pushed
the
gfay_feat_retrieve-bal-token
branch
from
5c8a2e7 to
1554e3b
Compare
MaGOs92
force-pushed
the
gfay_feat_retrieve-bal-token
branch
from
988193a to
0b9c4df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Le menu principal :
La vue public
La vue public sert aux partenaires pour suivre l'avançée des BAL quand celle ci n'est pas publiées. En réalité ce sont souvent les communes qui ont plus d'accès administrateur qui se retrouve dessus. Mise à part édition impossible en rouge avec aucune indication pour récupérer les accès.
Solutions :