-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Personas memories fix #1917
base: main
Are you sure you want to change the base?
Personas memories fix #1917
Conversation
mdmohsin7
commented
Feb 27, 2025
•
edited
Loading
edited
- 30s timeout for X api calls
- add try catch for sync_update_persona_prompt
- update the persona prompts async in a separate thread without disturbing the process_memory
1/ from my experience, this code block is the cause of websocket connection drop (/listen API). do you experience the same ? https://github.com/BasedHardware/omi/pull/1917/files#diff-e518096e8d0948a411d3035bacafc371d1a8600659b7b7f6ea667f73b2231dc4L195-R203 |
1/ I did not had issues when I was testing locally (with 30s timeout). I'll test it a bit more and maybe will move it to make it independent so no other function should be dependent on it |
1/ please do a small research. how does the thread impact to the python application ? |
@nquang29 babe, could you help Mohsin a bit with researching, why this code of block drop the WS connection sometime ? |
1/ sure will do, just occupied with somewhat more support tickets haha. And Quang has already been a lot helpful to me, and some more insights from him will only help me more |
i think this issue come from |