feat: support HttpClient configuration #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greathouse
commented
Jul 9, 2024
| @@ -172,6 +173,7 @@ namespace {{packageName}}.Client | |||
| {{>visibility}} partial class ApiClient : ISynchronousClient{{#supportsAsync}}, IAsynchronousClient{{/supportsAsync}} | |||
| { | |||
| private readonly string _baseUrl; | |||
| private HttpClient _httpClient; | |||
There was a problem hiding this comment.
Allowing the client to customize the HttpClient that RestSharp uses internally.
greathouse
commented
Jul 9, 2024
| MaxTimeout = configuration.Timeout, | ||
| Proxy = configuration.Proxy, | ||
| UserAgent = configuration.UserAgent | ||
| UserAgent = configuration.UserAgent, | ||
| ThrowOnAnyError = true |
There was a problem hiding this comment.
Throws all errors encountered during the http process.
greathouse
commented
Jul 9, 2024
| this.HeaderParameters.Add("BT-IDEMPOTENCY-KEY", value); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Convenience properties to set Basis Theory specific request headers.
greathouse
commented
Jul 9, 2024
| if(requestOptions == default(BasisTheory.net.Client.RequestOptions)) | ||
| { | ||
| requestOptions = new BasisTheory.net.Client.RequestOptions(); | ||
| } |
There was a problem hiding this comment.
Allowing the client to pass a RequestOptions object. The previous template created the RequestOptions internally.
dhudec
approved these changes
Jul 10, 2024
bt-platform-eng
pushed a commit
that referenced
this pull request
Jul 10, 2024
# [3.1.0](v3.0.0...v3.1.0) (2024-07-10) ### Features * support HttpClient configuration ([#259](#259)) ([8b5afc9](8b5afc9))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
genericHostoption as described in the conversation, but that had problems too (and is still marked as "experimental").BT-TRACE-IDandBT-IDEMPOTENCY-KEY). The original generated template did not pass in aRequestOptionsclass as parameters. I applied the patch found here: [REQ][csharp-netcore] Add Request Options as a parameter to the Wrapper API methods OpenAPITools/openapi-generator#11010. I had to make some minor modifications.CorrelationIdandIdempotencyKeyto theRequestOptionsas shortcuts to adding the request headers.TenantUserAuthenticationHandlerin the Admin API.Draft PR for the Developer Documentation: Basis-Theory/developers.basistheory.com#409
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist