Swapping version to git hash for cachbusting (#22)

Co-authored-by: Aurora Walker <[email protected]>

.github/workflows/release.yml

@@ -35,5 +35,5 @@ jobs:
         ECR_REPOSITORY: ${{ steps.get-repository.outputs.repository }}
         IMAGE_TAG: ${{ steps.get-version.outputs.version }}
       run: |
-        docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
+        docker build --build-arg APP_VERSION=$IMAGE_TAG -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
         docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG

Dockerfile

@@ -1,5 +1,8 @@
 FROM node:10.19-alpine AS build
 
+ARG APP_VERSION
+ENV APP_VERSION=$APP_VERSION
+
 COPY . .
 RUN npm ci
 RUN npm run build

entrypoint.sh

@@ -1,5 +1,6 @@
 #!/bin/sh
 
+# This APP_VERSION is set dyanamically at run time, and is not the same as in release.yaml which sets it on the build
 APP_VERSION=${APP_VERSION:-undefined}
 
 cat > /etc/nginx/nginx.conf <<EOF

src/utils/engine-client.js

@@ -2,10 +2,10 @@ import { streamAll } from "../io/websocket";
 import { makeQueryString, httpToWsProtocol, join } from "./url";
 import { loadSvgs, getSvg, svgExists } from "./inline-svg";
 import { isLastFrameOfGame } from "./game-state";
-import { version } from "../../package.json";
 
 const DEFAULT_SNAKE_HEAD = "default";
 const DEFAULT_SNAKE_TAIL = "default";
+const APP_VERSION = process.env.APP_VERSION;
 
 async function get(url, query) {
   const response = await fetch(url + makeQueryString(query));
@@ -92,8 +92,8 @@ function isIllegalSvgPath(nameOrPath) {
 }
 
 function svgUrlFromName(base, relative) {
-  //appending the app version allows for cache busting on deploy
-  const extension = ".svg?board_version=" + version;
+  //appending the image tag of this version allows for cache busting on deploy
+  const extension = ".svg?boardVersion=" + APP_VERSION;
   return join("https://media.battlesnake.com", base, relative) + extension;
 }