Closes #3864 max and min of bool to return bool like numpy

Bears-R-Us · Nov 15, 2024 · 1e28c6f · 1e28c6f
1 parent 0f5f0a3
commit 1e28c6f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/ReductionMsg.chpl b/src/ReductionMsg.chpl
@@ -92,18 +92,18 @@ module ReductionMsg
     }
 
     @arkouda.registerCommand
-    proc maxAll(const ref x:[?d] ?t, skipNan: bool): reductionReturnType(t) throws
+    proc maxAll(const ref x:[?d] ?t, skipNan: bool): t throws
       where t==int || t==real || t==uint(64) || t==bool
     {
       use SliceReductionOps;
       return getMaxSlice(x, x.domain, skipNan);
     }
 
     @arkouda.registerCommand
-    proc max(const ref x:[?d] ?t, axis: list(int), skipNan: bool): [] reductionReturnType(t) throws
+    proc max(const ref x:[?d] ?t, axis: list(int), skipNan: bool): [] t throws
       where t==int || t==real || t==uint(64) || t==bool {
       use SliceReductionOps;
-      type opType = reductionReturnType(t);
+      type opType = t;
       const (valid, axes) = validateNegativeAxes(axis, x.rank);
       if !valid {
         throw new Error("Invalid axis value(s) '%?' in slicing reduction".format(axis));
@@ -117,18 +117,18 @@ module ReductionMsg
     }
 
     @arkouda.registerCommand
-    proc minAll(const ref x:[?d] ?t, skipNan: bool): reductionReturnType(t) throws
+    proc minAll(const ref x:[?d] ?t, skipNan: bool): t throws
       where t==int || t==real || t==uint(64) || t==bool
     {
       use SliceReductionOps;
       return getMinSlice(x, x.domain, skipNan);
     }
 
     @arkouda.registerCommand
-    proc min(const ref x:[?d] ?t, axis: list(int), skipNan: bool): [] reductionReturnType(t) throws
+    proc min(const ref x:[?d] ?t, axis: list(int), skipNan: bool): [] t throws
       where t==int || t==real || t==uint(64) || t==bool {
       use SliceReductionOps;
-      type opType = reductionReturnType(t);
+      type opType = t;
       const (valid, axes) = validateNegativeAxes(axis, x.rank);
       if !valid {
         throw new Error("Invalid axis value(s) '%?' in slicing reduction".format(axis));