Causes error in registration of cumsum and cumprod functions #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in the comments starting at line 179 of src/EfuncMsg.chpl, this causes an error in the registration of the cumsum and cumprod functions, using the new user interface.
Each has two procs defined: one for input types int, uint and real, where output type = input type, and one for input type bool, where output = int.
Only the first of the procs is registered. In this example, one has the "bool" version first, and only that is registered, and the other has the "bool" version second, and it 's not registered.
I can get around this by making one proc for each, and using a separate function to assign the output type, but there is definitely an error somewhere in here.