Allow std::function as callback for AdsNotification #204
+147
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the library like so: find_package(Threads REQUIRED) find_package(ads REQUIRED) add_executable(myAdsApp myAdsApp.cpp) target_link_libraries(myAdsApp ads::ads)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #203
As AdsSyncAddDeviceNotificationReqEx must not be changed, I couldn't find any other solution than adapting
AdsLib/AdsDevice.cpp.PS: As I use this in my tooling, the other pull request of me #202 is also included. In case this is accepted, I can clean up and cherry-pick this.
Resolves: #203 and #142