fix #214: AttributeDict does not support hasattr #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 69.18% 69.20% +0.02%
==========================================
Files 22 22
Lines 3946 3949 +3
Branches 715 715
==========================================
+ Hits 2730 2733 +3
Misses 1036 1036
Partials 180 180
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
orbeckst
requested changes
Nov 11, 2023
tests/test_utilities.py
Outdated
| @@ -52,6 +52,11 @@ def test_dict_set(self): | |||
| self.d["gargl"] = "blaster" | |||
| assert self.d["gargl"] == "blaster" | |||
|
|
|||
| def test_dict_hasttr(self): | |||
There was a problem hiding this comment.
:-)
Suggested change
| def test_dict_hasttr(self): | |
| def test_dict_hasattr(self): |
orbeckst
approved these changes
Nov 11, 2023
|
cheers! |
jandom
deleted the
jandom/fix/210-attribute-dict-doesnt-support-hasattr
branch
|
Thanks for the speedy merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title