-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some more regex string fixes; and: use numpy.nan instead of numpy.NAN #288
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 22 22
Lines 3954 3954
=====================================
Misses 3954 3954 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. Sorry, I hadn't seen the PR.
I'll also add you to the CHANGES.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge the PR in a few days or sooner if I hear from you. Thank you for your contribution.
numpy-2 has dropped NAN and NaN
(numpy documentation still says "NaN and NAN are aliases of nan" but this is obviously wrong)