🎨 add phpstan config

.gitattributes

@@ -1,6 +1,7 @@
-.git*            export-ignore
-.php-cs-fixer.*  export-ignore
-docs/            export-ignore
-phpunit.xml.dist export-ignore
-README.md        export-ignore
-tests/           export-ignore
+/.git*            export-ignore
+/.php-cs-fixer.*  export-ignore
+/docs/            export-ignore
+/phpstan*         export-ignore
+/phpunit.xml.dist export-ignore
+/README.md        export-ignore
+/tests/           export-ignore

phpstan-baseline.neon

@@ -0,0 +1,12 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeDefinition\\:\\:children\\(\\)\\.$#"
+			count: 1
+			path: src/DependencyInjection/Configuration.php
+
+		-
+			message: "#^Else branch is unreachable because previous condition is always true\\.$#"
+			count: 1
+			path: src/Recaptcha/RecaptchaVerifier.php
+

phpstan.neon

@@ -0,0 +1,7 @@
+parameters:
+    level: 6
+    paths:
+        - src
+        - tests
+includes:
+    - phpstan-baseline.neon

src/DependencyInjection/BeelabRecaptcha2Extension.php

@@ -27,7 +27,7 @@ public function load(array $configs, ContainerBuilder $container): void
         $loader->load('services.xml');
     }
 
-    private function getRequestMethod($requestMethod): string
+    private function getRequestMethod(string $requestMethod): string
     {
         switch ($requestMethod) {
             case 'curl_post':

src/DependencyInjection/Compiler/TwigFormPass.php

@@ -26,12 +26,12 @@ public function process(ContainerBuilder $container): void
         }
 
         $reflection = new \ReflectionClass(BeelabRecaptcha2Bundle::class);
-        $path = \dirname($reflection->getFileName()).'/../templates';
+        $path = \dirname((string) $reflection->getFileName()).'/../templates';
         $loaderDefinition->addMethodCall('addPath', [$path]);
 
         $container->setParameter('twig.form.resources', \array_merge(
             ['form_fields.html.twig'],
-            $container->getParameter('twig.form.resources')
+            (array) $container->getParameter('twig.form.resources')
         ));
     }
 }

src/Recaptcha/RecaptchaVerifier.php

@@ -3,6 +3,7 @@
 namespace Beelab\Recaptcha2Bundle\Recaptcha;
 
 use ReCaptcha\ReCaptcha;
+use ReCaptcha\Response;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
 
@@ -50,6 +51,10 @@ public function verify(?string $recaptchaValue = null): void
             $recaptchaValue = $request->request->get(self::GOOGLE_DEFAULT_INPUT);
         }
 
+        if (null === $recaptchaValue || !is_string($recaptchaValue)) {
+            throw new RecaptchaException(new Response(false));
+        }
+
         $response = $this->reCaptcha->verify($recaptchaValue, $request->getClientIp());
         if (!$response->isSuccess()) {
             throw new RecaptchaException($response);

src/Validator/Constraints/Recaptcha2Validator.php

@@ -19,12 +19,15 @@ public function __construct(RecaptchaVerifier $verifier)
         $this->verifier = $verifier;
     }
 
+    /**
+     * @param string|null $value
+     * @param Recaptcha2  $constraint
+     */
     public function validate($value, Constraint $constraint): void
     {
         try {
             $this->verifier->verify($value);
         } catch (RecaptchaException $e) {
-            /* @var Recaptcha2 $constraint */
             $this->context->addViolation($constraint->message);
         }
     }

tests/DependencyInjection/BeelabRecaptcha2ExtensionTest.php

@@ -24,10 +24,10 @@ public function testLoadSetParameters(): void
 
         $extension = new BeelabRecaptcha2Extension();
         $configs = [
-            ['request_method' => 'curl_post'],
-            ['site_key' => 'foo'],
-            ['secret' => 'bar'],
-            ['enabled' => true],
+            'one' => ['request_method' => 'curl_post'],
+            'two' => ['site_key' => 'foo'],
+            'three' => ['secret' => 'bar'],
+            'four' => ['enabled' => true],
         ];
         $extension->load($configs, $container);
         self::assertInstanceOf(BeelabRecaptcha2Extension::class, $extension);
@@ -45,10 +45,10 @@ public function testLoadSetParametersPost(): void
 
         $extension = new BeelabRecaptcha2Extension();
         $configs = [
-            ['request_method' => 'post'],
-            ['site_key' => 'foo'],
-            ['secret' => 'bar'],
-            ['enabled' => true],
+            'one' => ['request_method' => 'post'],
+            'two' => ['site_key' => 'foo'],
+            'three' => ['secret' => 'bar'],
+            'four' => ['enabled' => true],
         ];
         $extension->load($configs, $container);
         self::assertInstanceOf(BeelabRecaptcha2Extension::class, $extension);

tests/Recaptcha/RecaptchaVerifierTest.php

@@ -12,10 +12,13 @@
 
 final class RecaptchaVerifierTest extends TestCase
 {
+    /** @var \PHPUnit\Framework\MockObject\MockObject|ReCaptcha */
     protected $recaptcha;
 
+    /** @var \PHPUnit\Framework\MockObject\MockObject|Request */
     protected $request;
 
+    /** @var \PHPUnit\Framework\MockObject\MockObject|RequestStack */
     protected $stack;
 
     protected function setUp(): void