Speed up ByondUI mounting (#10427)

BeeStation · Jan 8, 2024 · 2b5449a · 2b5449a
1 parent 2f128b4
commit 2b5449a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/tgui/packages/tgui/components/ByondUi.js b/tgui/packages/tgui/components/ByondUi.js
@@ -27,14 +27,15 @@ const createByondUiElement = (elementId) => {
     render: (params) => {
       logger.log(`rendering '${id}'`);
       byondUiStack[index] = id;
+      params['is-visible'] = 'true';
       Byond.winset(id, params);
       Byond.sendMessage('byondui_update', { mounting: true, id: id });
     },
     unmount: () => {
       logger.log(`unmounting '${id}'`);
       byondUiStack[index] = null;
       Byond.winset(id, {
-        parent: '',
+        'is-visible': 'false',
       });
       Byond.sendMessage('byondui_update', { mounting: false, id: id });
     },
@@ -49,7 +50,7 @@ window.addEventListener('beforeunload', () => {
       logger.log(`unmounting '${id}' (beforeunload)`);
       byondUiStack[index] = null;
       Byond.winset(id, {
-        parent: '',
+        'is-visible': 'false',
       });
       Byond.sendMessage('byondui_update', { mounting: false, id: id });
     }