Fix html encoding with brainwashing objectives in tgui (#9739)

BeeStation · Oct 6, 2023 · f3e2b1d · f3e2b1d
1 parent cb71d77
commit f3e2b1d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/tgui/packages/tgui/interfaces/AntagInfoBrainwashed.tsx b/tgui/packages/tgui/interfaces/AntagInfoBrainwashed.tsx
@@ -2,6 +2,7 @@ import { useBackend } from '../backend';
 import { Icon, Section, Stack } from '../components';
 import { BooleanLike } from 'common/react';
 import { Window } from '../layouts';
+import { sanitizeText } from '../sanitize';
 
 type Objective = {
   count: number;
@@ -44,7 +45,7 @@ export const AntagInfoBrainwashed = () => {
   );
 };
 
-const ObjectivePrintout = (props, context) => {
+const ObjectivePrintout = (_props, context) => {
   const { data } = useBackend<Info>(context);
   const { objectives } = data;
   return (
@@ -57,7 +58,13 @@ const ObjectivePrintout = (props, context) => {
           objectives.map((objective) => (
             <>
               <Stack.Item key={objective.count}>
-                {objective.count}. {objective.explanation}
+                {objective.count}.{' '}
+                <span
+                  // eslint-disable-next-line react/no-danger
+                  dangerouslySetInnerHTML={{
+                    __html: sanitizeText(objective.explanation), // brainwashing objectives are sanitized anyways
+                  }}
+                />
               </Stack.Item>
               <Stack.Item bold textColor="red">
                 This Directive must be followed.

diff --git a/tgui/packages/tgui/interfaces/common/ObjectiveSection.tsx b/tgui/packages/tgui/interfaces/common/ObjectiveSection.tsx
@@ -1,5 +1,5 @@
 import { BooleanLike } from 'common/react';
-import { Box, Section, Stack } from '../../components';
+import { Section, Stack } from '../../components';
 import { sanitizeText } from '../../sanitize';
 
 export type Objective = {