Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauls Observer UI #10050

Closed
wants to merge 5 commits into from
Closed

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Oct 19, 2023

Ports:

About The Pull Request

Adds spawner and Minigames menu from /tg/

Removes "Jump to Mob" Button

Why It's Good For The Game

The Spawners menu and CTF are both existing features that players can use, but its not obvious to new players because the former is hidden deep in the statpanel, and the latter requires you to know you can jump to it and click on it to request a CTF game to start.

Ghostroles/Minigames are a good way to practice game mechanics, especially for new players. It is a prerogative to make them more accessible.

I removed the Jump To Mob Button as it became redundant when we Converted the Orbit button to TGUI.

Testing Photographs and Procedure

Screenshots&Videos
SPAWNERS.1.mp4

Changelog

🆑 rkz, NamelessFairy, Mothblocks
add: added spawners button to observer UI
add: added Minigames button to observer UI
remove: removed Jump To Mob button from Observer UI. The Orbit button already lists all mobs and is the superior tool anyway. Admins can use Jump to Key anyway.
rscadd: minigame, spawner icons
/:cl:

@github-actions github-actions bot added Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Oct 19, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

IDIOT

image

STUPID MORON

@Tsar-Salat
Copy link
Contributor Author

ohhh my fucking gooooood

Copy link
Member

@itsmeow itsmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have enough ghost minigames to warrant a whole button and menu for it. My suggestion is adding a tab to the spawners menu and removing the minigames button, or merge spawners into the minigames button.

const teams = data.teams || [];
const enabled = data.enabled || [];
return (
<Window title="CTF Panel" width={700} height={600}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Window title="CTF Panel" width={700} height={600}>
<Window title="CTF Panel" width={700} height={600} theme="generic">

@itsmeow
Copy link
Member

itsmeow commented Oct 31, 2023

Also remove the mafia icon that was added.

@Tsar-Salat
Copy link
Contributor Author

We don't have enough ghost minigames to warrant a whole button and menu for i

Adding a button front and center so new players can see it and know CTF exists is a dealbreaker for me.

@Tsar-Salat Tsar-Salat closed this Oct 31, 2023
@itsmeow
Copy link
Member

itsmeow commented Oct 31, 2023

I didn't say that, I said having two buttons to do the same thing is unnecessary. You can use the minigames icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Mapping DMM Change Server Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants