-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhauls Observer UI #10050
Overhauls Observer UI #10050
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ohhh my fucking gooooood |
5c5144f
to
de77f96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have enough ghost minigames to warrant a whole button and menu for it. My suggestion is adding a tab to the spawners menu and removing the minigames button, or merge spawners into the minigames button.
const teams = data.teams || []; | ||
const enabled = data.enabled || []; | ||
return ( | ||
<Window title="CTF Panel" width={700} height={600}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Window title="CTF Panel" width={700} height={600}> | |
<Window title="CTF Panel" width={700} height={600} theme="generic"> |
Also remove the |
Adding a button front and center so new players can see it and know CTF exists is a dealbreaker for me. |
I didn't say that, I said having two buttons to do the same thing is unnecessary. You can use the minigames icon |
Ports:
About The Pull Request
Adds spawner and Minigames menu from /tg/
Removes "Jump to Mob" Button
Why It's Good For The Game
The Spawners menu and CTF are both existing features that players can use, but its not obvious to new players because the former is hidden deep in the statpanel, and the latter requires you to know you can jump to it and click on it to request a CTF game to start.
Ghostroles/Minigames are a good way to practice game mechanics, especially for new players. It is a prerogative to make them more accessible.
I removed the Jump To Mob Button as it became redundant when we Converted the Orbit button to TGUI.
Testing Photographs and Procedure
Screenshots&Videos
SPAWNERS.1.mp4
Changelog
🆑 rkz, NamelessFairy, Mothblocks
add: added spawners button to observer UI
add: added Minigames button to observer UI
remove: removed Jump To Mob button from Observer UI. The Orbit button already lists all mobs and is the superior tool anyway. Admins can use Jump to Key anyway.
rscadd: minigame, spawner icons
/:cl: