Replaces inconsistent implementations of the square root of 2 #10070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeow
approved these changes
Oct 23, 2023
EvilDragonfiend
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
in the code, the define SQRT_TWO was used at one place to approximate the square root of 2. At another place, the value was written directly. this PR replaces these inconsistent implementations with the inbuilt proc sqrt(2), which constant folds to 1.4142135.
Although this is not a port, this PR does the same thing as tgstation/tgstation#72913, which is listed in the "Things to Port" project: https://github.com/BeeStation/BeeStation-Hornet/projects/2#card-88347615
Why It's Good For The Game
using sqrt(2) is more readable and concise than a magic number or an obsolete define, and the computational cost is not increased.
Testing Photographs and Procedure
Screenshots&Videos
sqrt2proof.mov
According to approximate timing, the diagonal movement took about 1.4 times longer than the straight movement, which matches the expected value of sqrt(2).
Changelog
🆑
code: Square root of 2 is now only written as sqrt(2) in the code
/:cl: