Finishes the Mobility Refactor

[Tsar-Salat]

Status

• You now get a message for paralyzed limbs when inspecting yourself tgstation/tgstation#45952

Limbs

• Mobility refactor and code cleanup - lacking appendages edition tgstation/tgstation#52929
• limb disabled refactor tgstation/tgstation#53374

Removing update_mobility

• Mobility refactor: UI, pull and lying down edition tgstation/tgstation#54078
• Mobility refactor: no more update_mobility() tgstation/tgstation#54183

Fixes

• Fixes broken mobility interactions tgstation/tgstation#54320
• You can shake people up again tgstation/tgstation#54411

About The Pull Request

Status:

• The player checkhealth status now says if a limb is disabled.

Limbs A:

• Makes losing limbs event-based, as opposed to going through several long proc chains.
• Losing your legs gives you the floored trait, as long as not flying/floating.
• Losing your arms and legs gives you the immobile trait, as long as not flying/floating.
• Flying, even if you dont have limbs, will never apply limbless slowdown
• hacky get_legs_ignore() deprecated.
• renamed the dumb disabled to bodypart_disabled, so you can actually find it in searches
• relaymove() and driver_move() parameters properly typed and set.
• canBeHandcuffed() replaces the hacky get_arm_ignore()
• Miscellaneous Fixes

Limbs B:

• Fixes a bug with the previous PR in which paralysis did nothing. lmao
• kills is_disabled()
• changes several variable changes into events
• bodypart_disabled boolean'd
• Reduces an unnecessary amount of updates, as only extremity limbs really suffer from being disabled

Removing update_mobility

• Title

Fixes

• Stuff that Rohesie broke, that they later fixed

Additionally:

• I had to clean up how stamina was applies & heals a tiny bit. I made sure to inherit bacon's changes where Stamina heals slowly after the first second, rather than clearing in 10 like tg does. I think its clean, but tell me if the math looks wrong.

TODO:

• Initial
• Stamcrit applied correctly by weapons
• Stamcrit heals slowly (previous behavior not overwritten)
• Ensure no unintentional wound code ported over
• All mobility traits apply as expected
• 515 compatibility
• Paraplegic quirk people cannot walk
• Firefighter carrying still works

Why It's Good For The Game

This was an atomization, but the recent change to contributing.md and something bacon said changed my mind. We are finishing this in one pr. No more broken mobility, no more incorrect procs. One PR, fixing it here.

Mobility atomization, more responsive mobility overall
Mobility is a pretty bad proccall, as we need to call an update_x proc literally whenever something changes, or it wont take effect.

This makes that not happen, it just took 15 months.

Testing Photographs and Procedure

Screenshots&Videos

Disabler Stamcrit

dreamseeker_tjSeMZc4G9.mp4

Stungun stamcrit

dreamseeker_Djxeh8HJn1.mp4

Limb removal & nuggeting

dreamseeker_JZzdHNBXnM.mp4

Firefighter carrying

Roundstart Paraplegics cannot walk

dreamseeker_RvhQUOFBrW.mp4

Changelog

🆑 rkz, rohesie, tralezab, dwasint
add: You can now see if a limb is disabled through checkhealth (HUD, healthanalyzer, ghostscan)
tweak: being limbless while flying will never apply the limbless slowdown (because you are movin just fine, right?)
fix: minor stamina fixes in the way it is applied & healed
code: kills a lot of unecessary limb updating
code: makes Limb removal & disabling event-based. Extricate it from update_mobility
/:cl:

[Tsar-Salat]

#10078 is included in this, that should be merged prior to this one.

This will also need a "Needs TestMerge" label. Ive tested all the traits, which have all applied as expected. Stamina applies & heals as expected.

However, this PR is big enough that I think it would be smart to TM it

EDIT: 6/1/2024, 8 months after my original comment, this doesnt matter anymore. We are fine. Maints disregard.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Tsar-Salat]

Can confirm no intentional wounds code crossover as of 694274b

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Tsar-Salat]

Going to redo my tests after the psyphoza merge

[Tsar-Salat]

Ive gotten it to the point where everything basically works as expected... except parapalegia doesnt fucking do anything. At all.

Stamcrit works
missing limbs work
adding the limbs back work

but no, the Kiera Katsuras of the world get to walk. Travesty.

guhhh

[Tsar-Salat]

lets try... again.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[PowerfulBacon]

I trust whatever my old review said

[Tsar-Salat]

please dont break please dont break please dont break