Fixes VHT vine beams remaining indefinitely #10186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had similar issues with beams during Halloween event, will dig up the code which fixed it there and make suggestions soon™️ |
PowerfulBacon
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
closes #10185
Title
Why It's Good For The Game
There have been reported instances of Venus Human Traps vine beams not disappearing when they should.
This should address most of those circumstances in a very simple fashion. It's expected behavior that no beams exist if the mob is destroyed, so I expect no edge-cases to result from this.
Testing Photographs and Procedure
Screenshots&Videos
Deleting the mob in the middle of grabbing seemed like a good way to force the issue to occur, if my fix was insufficient
dreamseeker_ZIHvq96cCz.mp4
I had mass effect on in the background lmao
Changelog
🆑 rkz
fix: fixed Venus Human Traps vine beams not disappearing after successfully (or unsuccessfully) grabbing a mob
/:cl: