Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Bandoliers not Holding Shotgun Ammo (sorry) #10422

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

VickiMorris
Copy link
Contributor

image

About The Pull Request

Accidental double ComponentInitialize(), I was too hasty with my copy and pasting and failed to update a typepath. Regular bandoliers now hold shotguns shells again, and the western bandolier retains holding (slightly more) .38 special ammo as well.

Also is there a reason the can_hold list in the ComponentInitialize() procs are static? I added another static list to the western bandolier

Why It's Good For The Game

Fixes my fuckup, stuff working properly is good.

Testing Photographs and Procedure

Screenshots&Videos
Bandolier.mp4

Changelog

🆑 Impish_Delights
fix: Regular bandoliers hold shotgun ammo again. Whoops.
/:cl:

Accidental double ComponentInitialize(), I was way too hasty with my copy and pasting.

I can't make it parent the parent proc as the can_hold list is static, and I really don't wanna retype the western bandolier as it is a bandolier subtype. Might make something later that makes a generic bandolier the parent that just holds ammo.
@Rukofamicom Rukofamicom added this pull request to the merge queue Jan 6, 2024
Merged via the queue into BeeStation:master with commit aa0b635 Jan 6, 2024
8 checks passed
@VickiMorris VickiMorris deleted the bandolierFix branch January 18, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants