White Bandana - Small addition #10425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds white bandana
itsmeow
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Before this PR, when you tried to make a white bandana with cloth you'd make a botany bandana. Why? I don't know.
Now the white bandana exists.
I also made the white bandana the base for all bandanas, this is so to make adding more colours in the future easier and prepare for the Gagsification of bananas (my evil plan).
I plan to do this to most articles of clothing, I already made a white version of some items in #10371
This also allows players to dye them in whatever colour they want in game with a spray can, so win win.
I also removed some unnecessary bandana icon states that were duplicates (head sprites in mask file).
Why It's Good For The Game
I don't think there's anything I should mention here that I have nor already mentioned. I guess Consistency and player freedom.
Testing Photographs and Procedure
Screenshots&Videos
White bandana
Painting the bandana
Changelog
🆑 Pink Solene
add: added a white bandana
imageadd: added a white bandana sprite
imagedel: removed duplicate bandana sprites
tweak: creating a white bandana out of cloth actually creates a white bandana instead of a botany bandana now
code: changed the parent of bandanas to be a white bandana and made a bandana/botany variant for the botany one, then made the necessary changes to ensure botany bandanas appear where they are expected.
/:cl: